Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: improve unit test coverage of expression.go to 82.5% #3828

Merged
merged 3 commits into from
Jul 20, 2017
Merged

expression: improve unit test coverage of expression.go to 82.5% #3828

merged 3 commits into from
Jul 20, 2017

Conversation

XuHuaiyu
Copy link
Contributor

zz-jason
zz-jason reviewed Jul 20, 2017
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 20, 2017
@tiancaiamao
Copy link
Contributor

LGTM

@hanfei1991 hanfei1991 merged commit 9ee8476 into master Jul 20, 2017
@hanfei1991 hanfei1991 deleted the xhy/ut3 branch July 20, 2017 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@tiancaiamao tiancaiamao tiancaiamao approved these changes

Assignees
No one assigned
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuHuaiyu @tiancaiamao @zz-jason @hanfei1991